Cleanup key array logic to make llvm scan-build happier

We can't have the size != 0 without keys != NULL, but the fact we
checked one at the start and the other later was confusing the static
checks from scan-build. Use size in both places; it keeps scan-build
happy and make the code a little easier to read.

diff --git a/keyarray.c b/keyarray.c
index 8bade8ca193913330146c3dbe8d1332652692e9d..829339293d891149d534e2746866c4bec47630d8 100644 (file)
--- a/keyarray.c
+++ b/keyarray.c
@@ -71,7 +71,7 @@ bool array_add(struct keyarray *array, struct openpgp_fingerprint *fp)
        int  curpos = 0;
 
        found = false;
-       if (array->keys != NULL && array->count > 0) {
+       if (array->size != 0 && array->count > 0) {
                bottom = -1;
                top = array->count - 1;
                while ((top - bottom) > 1) {