X-Git-Url: https://the.earth.li/gitweb/?a=blobdiff_plain;f=keyid.c;h=d5244943f8e0c4480294900ad02c8577dc0b1fa2;hb=490c02ce72b7fa7cedecf7acaae46713fff507da;hp=6920ee478ef4bca7362bca7313047a199b01f02e;hpb=0f0f62d3505e60cac5fd35ebcdea525d9d79a3e1;p=onak.git

diff --git a/keyid.c b/keyid.c
index 6920ee4..d524494 100644
--- a/keyid.c
+++ b/keyid.c
@@ -13,8 +13,7 @@
  * more details.
  *
  * You should have received a copy of the GNU General Public License along with
- * this program; if not, write to the Free Software Foundation, Inc., 51
- * Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
+ * this program.  If not, see <https://www.gnu.org/licenses/>.
  */
 
 #include <string.h>
@@ -38,6 +37,19 @@
 #include "sha1.h"
 #endif
 
+uint64_t fingerprint2keyid(struct openpgp_fingerprint *fingerprint)
+{
+	uint64_t keyid;
+	int i;
+
+	for (keyid = 0, i = 12; i < 20; i++) {
+		keyid <<= 8;
+		keyid += fingerprint->fp[i];
+	}
+
+	return keyid;
+}
+
 
 /**
  *	get_keyid - Given a public key returns the keyid.
@@ -59,8 +71,7 @@ onak_status_t get_keyid(struct openpgp_publickey *publickey, uint64_t *keyid)
  *	which we've returned.
  */
 onak_status_t get_fingerprint(struct openpgp_packet *packet,
-	unsigned char *fingerprint,
-	size_t *len)
+	struct openpgp_fingerprint *fingerprint)
 {
 	struct sha1_ctx sha_ctx;
 	struct md5_ctx md5_context;
@@ -69,10 +80,8 @@ onak_status_t get_fingerprint(struct openpgp_packet *packet,
 
 	if (fingerprint == NULL)
 		return ONAK_E_INVALID_PARAM;
-	if (len == NULL)
-		return ONAK_E_INVALID_PARAM;
 
-	*len = 0;
+	fingerprint->length = 0;
 
 	switch (packet->data[0]) {
 	case 2:
@@ -90,8 +99,8 @@ onak_status_t get_fingerprint(struct openpgp_packet *packet,
 			 packet->data[11+modlen] + 7) >> 3;
 		md5_update(&md5_context, explen, &packet->data[12 + modlen]);
 
-		*len = 16;
-		md5_digest(&md5_context, *len, fingerprint);
+		fingerprint->length = 16;
+		md5_digest(&md5_context, fingerprint->length, fingerprint->fp);
 
 		break;
 
@@ -109,8 +118,8 @@ onak_status_t get_fingerprint(struct openpgp_packet *packet,
 		sha1_update(&sha_ctx, sizeof(c), &c);
 		sha1_update(&sha_ctx, packet->length,
 			packet->data);
-		*len = 20;
-		sha1_digest(&sha_ctx, *len, fingerprint);
+		fingerprint->length = 20;
+		sha1_digest(&sha_ctx, fingerprint->length, fingerprint->fp);
 
 		break;
 	default:
@@ -129,14 +138,13 @@ onak_status_t get_packetid(struct openpgp_packet *packet, uint64_t *keyid)
 {
 	int		offset = 0;
 	int		i = 0;
-	size_t		length = 0;
-	unsigned char	buff[20];
+	struct openpgp_fingerprint fingerprint;
 #ifdef NETTLE_WITH_RIPEMD160
 	struct ripemd160_ctx ripemd160_context;
 	uint8_t		data;
 #endif
 
-	if (packet == NULL)
+	if (packet == NULL || packet->data == NULL)
 		return ONAK_E_INVALID_PARAM;
 
 	switch (packet->data[0]) {
@@ -162,12 +170,10 @@ onak_status_t get_packetid(struct openpgp_packet *packet, uint64_t *keyid)
 
 			ripemd160_digest(&ripemd160_context,
 				RIPEMD160_DIGEST_SIZE,
-				buff);
+				fingerprint.fp);
+			fingerprint.length = RIPEMD160_DIGEST_SIZE;
 
-			for (*keyid = 0, i = 12; i < 20; i++) {
-				*keyid <<= 8;
-				*keyid += buff[i];
-			}
+			*keyid = fingerprint2keyid(&fingerprint);
 
 			return ONAK_E_OK;
 		}
@@ -197,12 +203,9 @@ onak_status_t get_packetid(struct openpgp_packet *packet, uint64_t *keyid)
 		}
 		break;
 	case 4:
-		get_fingerprint(packet, buff, &length);
-		
-		for (*keyid = 0, i = 12; i < 20; i++) {
-			*keyid <<= 8;
-			*keyid += buff[i];
-		}
+		get_fingerprint(packet, &fingerprint);
+
+		*keyid = fingerprint2keyid(&fingerprint);
 
 		break;
 	default: