Fix issues found by llvm scan-build static analysis

[onak.git] / keydb_keyd.c

diff --git a/keydb_keyd.c b/keydb_keyd.c
index 5fd084398d048568df01867785f24453c93304a4..1d10928fdec80146304ec50299329bb4d99662ae 100644 (file)
--- a/keydb_keyd.c
+++ b/keydb_keyd.c
@@ -489,7 +489,6 @@ static void keyd_cleanupdb(struct onak_dbctx *dbctx)
                logthing(LOGTHING_NOTICE, "Error closing down socket: %d",
                                errno);
        }
-       keyd_fd = -1;
 
        free(dbctx);
 
@@ -559,6 +558,13 @@ struct onak_dbctx *keydb_keyd_init(bool readonly)
                        }
 
                        count = read(keyd_fd, &reply, sizeof(reply));
+                       if (count != sizeof(reply)) {
+                               logthing(LOGTHING_CRITICAL,
+                                       "Error! Unexpected keyd version "
+                                       "length: %d != %d",
+                                       count, sizeof(reply));
+                               exit(EXIT_FAILURE);
+                       }
                        logthing(LOGTHING_DEBUG,
                                        "keyd protocol version %d",
                                        reply);